Allon Mureinik has posted comments on this change.
Change subject: core: Added get all vith config to SnapshotDao
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments)
basically looks good, see some minor inline comments
....................................................
File backend/manager/dbscripts/snapshots_sp.sql
Line 155: CASE WHEN v_fill_configuration = TRUE THEN
vm_configuration ELSE NULL END,
Note the database specs are a bit funny about empty strings ('').
Postgres that we use supports such a value, but lots of them treat it as a NULL
literal, which may cause issues if we ever want to migrate.
consider changing the "vm_configuration != ''" condition to
"length(vm_configuration) > 0".
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDao.java
Line 71: * The VM id.
I think "ordered by creation date" would be clearer than "ordered by date"
....................................................
Commit Message
Line 6:
vith->with :-)
--
To view, visit http://gerrit.ovirt.org/3035
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b5a0d4af2c78805720bf17da5e84fc077e3f22f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
