Allon Mureinik has posted comments on this change. Change subject: engine-core: remove singleton from QuotaHelper ......................................................................
Patch Set 2: Looks good to me, but someone else must approve I think singletons are slightly more comfortable if we ever want to introduce any form of dependency injection, but i agree with both of you that we currently don't have any real reason for it, -- To view, visit http://gerrit.ovirt.org/3008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I595d44574ae641eeed7cd36a65647c0de474770b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches