Maor Lipchuk has posted comments on this change.
Change subject: engine-core: remove singleton from QuotaHelper
......................................................................
Patch Set 2: (1 inline comment)
I think keeping it singleton will help it be more flexibility in the future
when we want to use state, since this helper class was meant to be for add and
update quota.
but for now I agree there is no real reason to keep it that way.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaHelper.java
Line 302: static QuotaDAO getQuotaDAO() {
This method can be private,
I will remove the other getDAOs methods in another patch since they are not
usable.
--
To view, visit http://gerrit.ovirt.org/3008
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I595d44574ae641eeed7cd36a65647c0de474770b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
