Michael Kublin has posted comments on this change.
Change subject: DO NOT SUBMIT core: Introducing AddVmFromSnapshot command
......................................................................
Patch Set 23: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
Line 67: public NGuid getStorageDomainId() {
Each time a method called, we are running a new query?
Line 69: List<DiskImage> images =
getDiskImageDao().getAllSnapshotsForVmSnapshot(sourceSnapshotId);
Why use here ImagesHandler.getStorageDomainId? What is a reason?
Why anyone will write a method ImagesHandler.getStorageDomainId.
Line 112: diskImage,
Same here, why use ImagesHandler.getStorageDomainId
Line 285:
I think that such methods should be at parent class
Line 375:
That method is bad, from performance point of view, and the check can be
written in one line
--
To view, visit http://gerrit.ovirt.org/2300
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ac7e0c801faf6bca9932c5ed47dc6a065c1ac51
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
