Mike Kolesnik has posted comments on this change.
Change subject: DO NOT SUBMIT core: Introducing AddVmFromSnapshot command
......................................................................
Patch Set 19: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
Line 40: @LockIdNameAttribute(fieldName = "sourceSnapshotId")
Why add this annotation?
Line 68: public NGuid getStorageDomainId() {
Isn't this check only for single domain?
I thought the command should support multiple storage domains.
Line 264:
getCompensationContext().snapshotEntityStatus(getVm().getDynamicData(),
VMStatus.ImageLocked);
Huh?
--
To view, visit http://gerrit.ovirt.org/2300
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ac7e0c801faf6bca9932c5ed47dc6a065c1ac51
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
