Mike Kolesnik has posted comments on this change. Change subject: DO NOT SUBMIT core: Adding snapshotExists to SnapshotValidator ......................................................................
Patch Set 7: Looks good to me, approved (1 inline comment) Basically very good, a minor comment for your consideration .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidatorTest.java Line 84: assertEquals(isValid, validationResult.isValid()); You can even go the extra mile here, if you want, and extract the assertion code to a shared method since it is also copy pasted :) -- To view, visit http://gerrit.ovirt.org/2543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64604ada49505224d45e0ce30a20095c3a6e79fe Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
