Moti Asayag has posted comments on this change.
Change subject: core: Adding snapshotExists to SnapshotValidator
......................................................................
Patch Set 1: (1 inline comment)
Adding Kublin since he had an issue not to favor those validators.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidator.java
Line 38: if (!getSnapshotDao().exists(snapshotId)) {
Kublin claims this validator performs additional actions such as creating an
instances only for the sake of adding a message to a list, while this could
have been replaced with a plan condition in can-do-action, or with a method for
keeping the code cleaner Therefore this validator shouldn't be embraced.
--
To view, visit http://gerrit.ovirt.org/2543
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64604ada49505224d45e0ce30a20095c3a6e79fe
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
