Mark Wu has posted comments on this change.
Change subject: Add more detailed memory statistics function to guest agent.
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File ovirt-guest-agent/GuestAgentWin32.py
Line 335: colItems = objSWbemServices.ExecQuery("SELECT * FROM
Win32_PerfFormattedData_PerfOS_Memory")
I didn't run it as a Windows service, and instead I just run the script
GuestAgentWin32.py directly. If I run the executable(exe) file converted from
OVirtGuestService.py, it will be run as a service, right? I will give it a
try. Thanks!
....................................................
File ovirt-guest-agent/OVirtAgentLogic.py
Line 187: self.vio.write('memory-stats', { 'memory' :
self.dr.getMemoryStats() })
Ah, before memory stats was implemented as a separate statistics function, like
disk usages. Now it's merged into 'heartbeat', so this function becomes
useless. I will remove it. If we need a separate command invoked from vdsm to
collect memory stats in future, we can add it again.
--
To view, visit http://gerrit.ovirt.org/2272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic93b8717f99f033caf2b5dc2404a55f903bf4b0a
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Gal Hammer <gham...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
