Ofer Schreiber has posted comments on this change.
Change subject: packaging: Remote DB support
......................................................................
Patch Set 16: Fails
(7 inline comments)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 404: self.db_altered = False
I don't see where are you using this in the class, I think we should check in
the restore func
Line 423: if self.updated:
condition is missing
Line 463: if origname and newname:
Do we really need this check?
Line 628: logging.error("Failed to rename DB '%s'. Check that
there are currently no active connections.", basedefs.DB_NAME)
Errors printed to user should be in a CONST
Line 631: raise Exception("\nFailed to rename DB. Check that
there are currently no active connections.\n")
same here
Line 633: db.db_altered = True
I think rename_db should be a method in the DB class.
you shouldn't touch this outside the class.
so all this logic will be held inside a single function, and not in the main...
Line 661: except Exception,e:
no need for this change this, you are not using the "e"
--
To view, visit http://gerrit.ovirt.org/2245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab66d6f8ffe33f9674e79753df7541c212012190
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Anonymous Coward #1000140
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
