Allon Mureinik has posted comments on this change. Change subject: core-db: Added stored procedures for bridgeless networks BL ......................................................................
Patch Set 6: (5 inline comments) Have some (minor) inline comments. .................................................... File backend/manager/dbscripts/network_actions_sp.sql Line 20: WHERE please comment this constant Line 35: AND please comment this constant. .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkActionsDAODbFacadeImpl.java Line 7: Is it true to assume this DAO is always called in admin context? If not - it should also pass the userID to the SP for filtering. .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkActionsDAO.java Line 8: * Are there any running host on a cluster that have the specified network implemented over a bridge?. Only such host => hosts interfaces => interface Please document the @param and @return tags, or remove them. Line 16: /** Please document the @param and @return tags, or remove them. -- To view, visit http://gerrit.ovirt.org/2317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I820ac8d1c161e53f4b79c8d70cca4c4c66df2de9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
