Allon Mureinik has posted comments on this change. Change subject: core-db: Added stored procedures for bridgeless networks BL ......................................................................
Patch Set 2: (3 inline comments) Have some comments on inline the SQL files. Also - it's unclear to me who the java code interacts with the new stored procedures you added. Perhaps they should be removed from this commit and added to a future commit that contains the java code that uses them? .................................................... File backend/manager/dbscripts/vds_sp.sql Line 780: CREATE OR REPLACE FUNCTION getHostsIdsWithBridgedNetwork(v_cluster_id UUID, v_network_name VARCHAR(50)) v_network_name is not used in this procedure. I think this is a bug and you forgot something like nic.network_name = v_network_name. Also, as the query is right now, it's unclear to me why you need to join with "network". Line 800: WHERE please comment the "3" .................................................... File backend/manager/dbscripts/vms_sp.sql Line 923: AND please comment the hardcoded "1" -- To view, visit http://gerrit.ovirt.org/2317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I820ac8d1c161e53f4b79c8d70cca4c4c66df2de9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
