Michael Kublin has posted comments on this change. Change subject: core: Prestarted Vm (2) ......................................................................
Patch Set 10: Looks good to me, approved (1 inline comment) I don't want to stop commit, but please send a next patch where u are removing a following queries from .sql files. Getimage_vm_pool_mapByimage_guid Insertimage_vm_pool_map Deleteimage_vm_pool_map Getimage_vm_pool_mapByvm_guid I think we don't need them anymore because of u removed it already from calling in Java .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java Line 134: java.util.ArrayList<String> messages = new java.util.ArrayList<String>(); During rebase, just pass a new ArrayList() to IsVmfree no need for variable -- To view, visit http://gerrit.ovirt.org/1798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3c0b0d69c0da82d3ba2dcbcf045cd92a6db7bef Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msa...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Muli Salem <msa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
