Mike Kolesnik has posted comments on this change. Change subject: core: DO NOT SUBMIT BLL: Using DiskImage instead of DiskImage template ......................................................................
Patch Set 11: I would prefer that you didn't submit this (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java Line 325: new VmDeviceId((Guid) image.getId(), image.getvm_guid()), should be image.getimage_group_id() Line 389: DbFacade.getInstance().getVmDeviceDAO().remove(new VmDeviceId(image.getId(),image.getvm_guid())); should be image.getimage_group_id() .................................................... File backend/manager/modules/dal/src/test/filters/pgsql.properties Line 1: engine.db.username = postgres DO NOT PUSH -- To view, visit http://gerrit.ovirt.org/1570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I701bc85d005e3b1636feb8cb6cedca099356614c Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
