Mike Kolesnik has posted comments on this change. Change subject: core: DO NOT SUBMIT BLL: Using DiskImage instead of DiskImage template ......................................................................
Patch Set 9: (4 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java Line 24: private DiskImage diskOfTemplate; I think you can delete this field if its unused .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java Line 94: setSucceeded(true); Please indent correctly Line 132: DbFacade.getInstance().getDiskImageDAO().remove(getDestinationImageId()); Shouldn't you remove the ImageVmMap you have added? .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java Line 388: DbFacade.getInstance().getDiskDao().remove(image.getimage_group_id()); Shouldn't you remove the VMDevice & ImageVmMap also? -- To view, visit http://gerrit.ovirt.org/1570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I701bc85d005e3b1636feb8cb6cedca099356614c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
