Shahar Havivi has posted comments on this change.
Change subject: engine-core: add validations on VdsNetworkInterface
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkInterfaceValidator.java
Line 32: if (!"ovirtmgmt".equals(iface.getNetworkName()) &&
!isNullOrEmpty(iface.getGateway())) {
Don't forget to change the hardcoded ovirtmgmt to const in networkutils class
--
To view, visit http://gerrit.ovirt.org/1060
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie90a25bc30c948c444ea4823c9a2aba7628ba94d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
