Roy Golan has posted comments on this change.
Change subject: rest-api: exposing setupnetworks action under
/api/hosts/{id}/nics
......................................................................
Patch Set 6: (6 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/BootProtocol.java
Line 23:
Done
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 1120: action.host_nics.host_nic.bonding.slaves.host_nic--LIST:
{name|id: 'xs:string'}
Done
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java
Line 184: }
when attaching the network to an interface by id I need the network name.
without it its null although the user set the right ID
Line 348: private List<VdsNetworkInterface> nicsToInterfaces(List<HostNIC>
hostNics) {
Done
Line 357: ifaces.add(slaveIface);
the xml is describing the slaves under a single host_nic and I didn't get it
for sure.
The only reason I added this method is because I was missing the interfaces
....................................................
Commit Message
Line 11:
will send tests.
Can you point me to the the step of creating the SDK?
--
To view, visit http://gerrit.ovirt.org/1112
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9464f344605b99a21806170cf340e8fd8063dff6
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: ol...@redhat.com
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
