Yair Zaslavsky has posted comments on this change. Change subject: core: Changing originType enum (#786673) ......................................................................
Patch Set 4: (2 inline comments) .................................................... File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java Line 520 A comment for both mappers - This was code inserted to REST API to map "RHEV" String to the Engine enum literal , which has the int value of 0, and the enum.properties (UI) srtring represenation of "RHEV" - so basically, we map here "RHEV" string from user to 0 (for ovf) and to "RHEV" Strring to be presented by UI. This issue is taken care of at my fix, as : a. Engine enum literal (OriignType.Engine) was renamed to RHEV, according to your advice b. OriginType.RHEV( in my fix) now has an int value of 0. I hope this also answers your previous question on the patch. Line 529 Explained above. -- To view, visit http://gerrit.ovirt.org/1600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id60ef7a3117f8b11cdd5a896a14e8793239ae2c7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
