Itamar Heim has posted comments on this change. Change subject: core: Changing originType enum (#786673) ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) see my request to change the enums to match historical behavior .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/OriginType.java Line 16: RHEV(3); Engine is a bad name. and rhev was already 0 before ovirt was here. so please change: RHEV(0) OVIRT(3) -- To view, visit http://gerrit.ovirt.org/1600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id60ef7a3117f8b11cdd5a896a14e8793239ae2c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
