Moti Asayag has posted comments on this change. Change subject: core: Task Manager Add stored-procedures ......................................................................
Patch Set 4: (2 inline comments) .................................................... File backend/manager/dbscripts/job_sp.sql Line 425: where step.external_id is not null); the purpose of the statement is to update job which have no step with vdsm tasks running (identified by external_id != null). job_id is not null field for both Step and Job tables. Line 432: where step.external_id is not null); I'll remove the step alias. The purpose of this statement is to update steps which their jobs has no vdsm tasks. Negating the condition violates the purpose of the query or requires another loop over the job table to find those jobs which don't comply to the positive query. however I do miss here the update for the end_time which i'll add in next patch. -- To view, visit http://gerrit.ovirt.org/1084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib991f991824894aa4fee91754104d67b965aabda Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
