Doron Fediuck has posted comments on this change. Change subject: core : adding common utilities for VmDevice - VmDeviceCommonUtils ......................................................................
Patch Set 3: (2 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java Line 28: * Computes old boot sequence enum value from the given list of devices. If this class is common, I'd expect to find here the new one as well. Any reason it's missing? Line 56: ret = bs; break; ? -- To view, visit http://gerrit.ovirt.org/1163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie61cccbe2c866997558dc84041fb0c588133f8a8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
