Doron Fediuck has posted comments on this change. Change subject: core: porting old boot order values to new vm_device ......................................................................
Patch Set 3: (2 inline comments) .................................................... File backend/manager/dbscripts/upgrade/03_01_0160_vm_device_upgrade_data.sql Line 13: if (v_new_num_of_monitors != v_old_num_of_monitors) then Is this re-entrant? If so, we may have an issue below. Line 78: CREATE OR REPLACE FUNCTION set_vm_devices_boot_order_03_01_0140(v_vm_id UUID) The name here is confusing. Can you consider renaming it to set_all_vm_devices_xxx? -- To view, visit http://gerrit.ovirt.org/1162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2711269844ad5e874bc9a75131fbf649f459c79 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
