Michael Kublin has posted comments on this change. Change subject: engine: bad performance in storage_domains.getQueryableId() (#769615) ......................................................................
Patch Set 7: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_domains.java Line 284: return getid().toString() + "_" + (getstorage_pool_id() != null ? getstorage_pool_id().getValue().toString() : Guid.Empty.toString()); Why not make it is like a constant and calculate only once, storagePoolId is changed setStoragePoolId() is called only during retrieving information from DB and in some internal flows, I don't think that it ever change in GUI, so it is look like that getQueryableId() can be calculated only once -- To view, visit http://gerrit.ovirt.org/1111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2699668e938774a68c011626336f0e4d54f532af Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Danny Rankevich <danny....@redhat.com> Gerrit-Reviewer: Danny Rankevich <danny....@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
