Danny Rankevich has posted comments on this change. Change subject: engine: bad performance in storage_domains.getQueryableId() (#769615) ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_domains.java Line 283: // using '+' instead of String Format to prevent overhead, since this method is used heavily during UI rendering A '+' operator in Java between two Strings is always compiled as a call to StringBuilder.append(). So if there is only one statement of concatenation, the result is the same. When you concatenate the same String over several statements, using a single instance of a StringBuilder would be better than creating a new StringBuilder instance for each statement, which is what the compiler does. -- To view, visit http://gerrit.ovirt.org/1111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2699668e938774a68c011626336f0e4d54f532af Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Danny Rankevich <danny....@redhat.com> Gerrit-Reviewer: Danny Rankevich <danny....@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
