Yair Zaslavsky has posted comments on this change. Change subject: engine-core: minor copypaste cleanup ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AdGroupDAODbFacadeImpl.java Line 19: @Override If you're already doing some improvements, can you hold a single static instance for the mapper , instead of using "new" in each call to the getXXXX methods? -- To view, visit http://gerrit.ovirt.org/551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9a8f7bbc71a591f7229f2f5ef41dde5021d5827 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Jonathan Choate <jcho...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Salem Muli <msale...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
