Maor Lipchuk has posted comments on this change. Change subject: ovirt-engine: Add quota usage functions ......................................................................
Patch Set 1: (4 inline comments) .................................................... File backend/manager/dbscripts/upgrade/03_01_0140_add_quota_functions.sql Line 13: AND vm_dynamic.status not in (0, 13) Done Line 22: CREATE OR REPLACE FUNCTION CalculateVRAMUsage(v_quota_id UUID, v_vds_group_id UUID) Done Line 32: AND vm_dynamic.status not in (0, 13) Done. Line 37: LANGUAGE plpgsql; Actually, since this values, are reflected as rows from the view, the function will still be called twice, even if I will use only one function. Although for DRY reasons, you're right. I will change it, to use only one function. -- To view, visit http://gerrit.ovirt.org/1000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa6caf21f3170b8e69a7a154a483d605b71e0327 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
