Omer Frenkel has posted comments on this change. Change subject: ovirt-engine: Add quota usage functions ......................................................................
Patch Set 1: (4 inline comments) .................................................... File backend/manager/dbscripts/upgrade/03_01_0140_add_quota_functions.sql Line 13: AND vm_dynamic.status not in (0, 13) currently ImageLocked (15) status is not an option for a running vm (ImageIllegal-14 as well but its not in use AFAIK) Line 22: CREATE OR REPLACE FUNCTION CalculateVRAMUsage(v_quota_id UUID, v_vds_group_id UUID) maybe call it MemUsage (to match the field name) Line 32: AND vm_dynamic.status not in (0, 13) same same Line 37: LANGUAGE plpgsql; why not unify both to one function? is there a scenario when only cpu is needed on mem isn't? (or the other way) -- To view, visit http://gerrit.ovirt.org/1000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa6caf21f3170b8e69a7a154a483d605b71e0327 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
