Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: ccc95703cd8be092c490d6b37ea4ab5787317411
https://github.com/tianocore/edk2/commit/ccc95703cd8be092c490d6b37ea4ab5787317411
Author: abuthahirm <[email protected]>
Date: 2026-05-01 (Fri, 01 May 2026)
Changed paths:
M NetworkPkg/Ip4Dxe/Ip4Config2Nv.c
Log Message:
-----------
NetworkPkg/Ip4Dxe: Fix missing Status check on Ip4Cfg2->SetData call
In Ip4Config2ConvertIfrNvDataToConfigNvData(), when the policy is
changed away from a static configuration (PolicyChanged is TRUE), the
first call to Ip4Cfg2->SetData() was not checking its return value and
always returned EFI_SUCCESS. Fix this to check and return Status on
error, consistent with the second SetData call in the same function.
Cc: Saloni Kasbekar <[email protected]>
Cc: Zachary Clark-williams <[email protected]>
Signed-off-by: abuthahirm <[email protected]>
Commit: 6d4e973807846201e598b3c5e919c5f85f6f3675
https://github.com/tianocore/edk2/commit/6d4e973807846201e598b3c5e919c5f85f6f3675
Author: abuthahirm <[email protected]>
Date: 2026-05-01 (Fri, 01 May 2026)
Changed paths:
M NetworkPkg/DnsDxe/DnsImpl.c
Log Message:
-----------
NetworkPkg/DnsDxe: Refactor answer loop to for in ParseDnsResponse
The answer section loop in ParseDnsResponse() iterated a counter
AnswerSectionNum from 0 to DnsHeader->AnswersNum using a while loop
with a manual increment at the bottom. Convert it to an equivalent
for loop to make the initialization, condition, and increment
explicit.
Also replace the unconditional Status = EFI_NOT_FOUND assignment
before the loop with a conditional that only sets it when the loop
is never entered (DnsHeader->AnswersNum == 0). ParseDnsResponse()
initializes Status to EFI_SUCCESS at function entry, and the loop
body always overwrites Status, so the pre-assignment was dead code
in the common case. The conditional form makes the intent explicit:
EFI_NOT_FOUND is only the result when there are no answer records.
Cc: Saloni Kasbekar <[email protected]>
Cc: Zachary Clark-williams <[email protected]>
Signed-off-by: abuthahirm <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/f1f89f454cd8...6d4e97380784
To unsubscribe from these emails, change your notification settings at
https://github.com/tianocore/edk2/settings/notifications
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
