Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: 680ee2e3e9b1ed0b5a8d8c3262f355ea65a2175c
      
https://github.com/tianocore/edk2/commit/680ee2e3e9b1ed0b5a8d8c3262f355ea65a2175c
  Author: Pierre Gondois <[email protected]>
  Date:   2026-05-01 (Fri, 01 May 2026)

  Changed paths:
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c

  Log Message:
  -----------
  ShellPkg/Cls: Factorize color parsing

Signed-off-by: Pierre Gondois <[email protected]>


  Commit: 899b8b8550f88cc9ac5b5aea7640777b24c90166
      
https://github.com/tianocore/edk2/commit/899b8b8550f88cc9ac5b5aea7640777b24c90166
  Author: Pierre Gondois <[email protected]>
  Date:   2026-05-01 (Fri, 01 May 2026)

  Changed paths:
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c

  Log Message:
  -----------
  ShellPkg/Type: Factorize character display

Signed-off-by: Pierre Gondois <[email protected]>


  Commit: a219f8cfc541ca7c93c8bf614998621d97110c03
      
https://github.com/tianocore/edk2/commit/a219f8cfc541ca7c93c8bf614998621d97110c03
  Author: Pierre Gondois <[email protected]>
  Date:   2026-05-01 (Fri, 01 May 2026)

  Changed paths:
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c

  Log Message:
  -----------
  ShellPkg/Help: Free package on all paths

Signed-off-by: Pierre Gondois <[email protected]>


  Commit: 49ba46ec0ae6f8b496800f3db55cd1369d326483
      
https://github.com/tianocore/edk2/commit/49ba46ec0ae6f8b496800f3db55cd1369d326483
  Author: Pierre Gondois <[email protected]>
  Date:   2026-05-01 (Fri, 01 May 2026)

  Changed paths:
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Alias.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Echo.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/GetMtc.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Pause.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Ver.c

  Log Message:
  -----------
  ShellPkg/UefiShellLevel3: Return if ShellCommandLineParse() failed

This patch aims to help breaking down the long function present in
the ShellPkg and reduce complexity/nested code and conditions.

Return directly if ShellCommandLineParse() returned an error Status.
In such case, the "Package" that should be allocated by
ShellCommandLineParse() is already freed in:
ShellCommandLineParse()
\-ShellCommandLineParseEx()
\-InternalCommandLineParse()
so there is no need to free it with ShellCommandLineFreeVarList().

No functional change should be induced by this patch.

Signed-off-by: Pierre Gondois <[email protected]>


  Commit: 014d8fb941f8d66455e7960a6b2b26ca2030e159
      
https://github.com/tianocore/edk2/commit/014d8fb941f8d66455e7960a6b2b26ca2030e159
  Author: Pierre Gondois <[email protected]>
  Date:   2026-05-01 (Fri, 01 May 2026)

  Changed paths:
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Alias.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Echo.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/GetMtc.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Pause.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Ver.c

  Log Message:
  -----------
  ShellPkg/UefiShellLevel3: Extract MainCmdXXX() function

This patch aims to help breaking down the long function present in
the ShellPkg and reduce complexity/nested code and conditions.

Extract a MainCmdXXX() function for each shell command.
This command contains the possible operations the command aims
to operate. The ShellCommandRunXXX() function from which it
is extracted is only responsible of:
- initializing the shell/command environment
- parsing the command parameter and creating a Package
- freeing the Package

No functional change should be induced by this patch.

Signed-off-by: Pierre Gondois <[email protected]>


  Commit: 27c785b0df7f6ef327a07b32c1680ecfc389ded4
      
https://github.com/tianocore/edk2/commit/27c785b0df7f6ef327a07b32c1680ecfc389ded4
  Author: Pierre Gondois <[email protected]>
  Date:   2026-05-01 (Fri, 01 May 2026)

  Changed paths:
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c

  Log Message:
  -----------
  ShellPkg/UefiShellLevel3: Extract ProcessFileList() function

Extract a ProcessFileList() in:
- Touch.c
- Type.c
to lower the indentation level and simplify the logic.

No functional change should be induced by this patch.

Signed-off-by: Pierre Gondois <[email protected]>


  Commit: 8b5c970c55a723a42cc239ae6b0b03a01c32d464
      
https://github.com/tianocore/edk2/commit/8b5c970c55a723a42cc239ae6b0b03a01c32d464
  Author: Pierre Gondois <[email protected]>
  Date:   2026-05-01 (Fri, 01 May 2026)

  Changed paths:
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c

  Log Message:
  -----------
  ShellPkg/Help: Extract PrintMatchingHelp() function

Extract a PrintMatchingHelp() function in the Help command
to help splitting the logic MainCmdHelp() function.

No functional change should be induced by this patch.

Signed-off-by: Pierre Gondois <[email protected]>


  Commit: f1f89f454cd8c9aabae7ce5e690f612bd969f5ff
      
https://github.com/tianocore/edk2/commit/f1f89f454cd8c9aabae7ce5e690f612bd969f5ff
  Author: Pierre Gondois <[email protected]>
  Date:   2026-05-01 (Fri, 01 May 2026)

  Changed paths:
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Echo.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/GetMtc.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Pause.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c
    M ShellPkg/Library/UefiShellLevel3CommandsLib/Ver.c

  Log Message:
  -----------
  ShellPkg/UefiShellLevel3: Lower indentation level in MainCmdXXX()

This patch aims to help breaking down the long function present in
the ShellPkg and reduce complexity/nested code and conditions.

Lower the indentation level in the newly created MainCmdXXX()
functions.

Some ASSERT() are removed in Help.c as they check variables
which were initialized a few lines above.

No functional change should be induced by this patch.

Signed-off-by: Pierre Gondois <[email protected]>


Compare: https://github.com/tianocore/edk2/compare/68662fd712b9...f1f89f454cd8

To unsubscribe from these emails, change your notification settings at 
https://github.com/tianocore/edk2/settings/notifications


_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to