> -----Original Message----- > From: David Laight <[email protected]> > Sent: Monday, 15 April 2019 8:21 PM > To: 'Alastair D'Silva' <[email protected]>; 'Petr Mladek' > <[email protected]> > Cc: 'Alastair D'Silva' <[email protected]>; 'Jani Nikula' > <[email protected]>; 'Joonas Lahtinen' > <[email protected]>; 'Rodrigo Vivi' <[email protected]>; > 'David Airlie' <[email protected]>; 'Daniel Vetter' <[email protected]>; 'Karsten > Keil' <[email protected]>; 'Jassi Brar' <[email protected]>; 'Tom > Lendacky' <[email protected]>; 'David S. Miller' > <[email protected]>; 'Jose Abreu' <[email protected]>; 'Kalle > Valo' <[email protected]>; 'Stanislaw Gruszka' <[email protected]>; > 'Benson Leung' <[email protected]>; 'Enric Balletbo i Serra' > <[email protected]>; 'James E.J. Bottomley' > <[email protected]>; 'Martin K. Petersen' <[email protected]>; > 'Greg Kroah-Hartman' <[email protected]>; 'Alexander Viro' > <[email protected]>; 'Sergey Senozhatsky' > <[email protected]>; 'Steven Rostedt' > <[email protected]>; 'Andrew Morton' <[email protected]>; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; > [email protected]; [email protected] > Subject: RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in > hex_dump_to_buffer with flags > > From: Alastair D'Silva > > Sent: 15 April 2019 11:07 > ... > > In the above example the author only wants the hex output, while in > > other situations, both hex & ASCII output is desirable. If you just > > want ASCII output, the caller should just use a printk or one of it's > wrappers. > > Hexdump will 'sanitise' the ASCII. >
This is functionality that doesn't exist in the current hexdump implementation (you always get the hex version). I think a better option would be to factor out the sanitisation and expose that as a separate function. > Although I think you'd want a 'no hex' flag to suppress the hex. > > Probably more useful flags are ones to suppress the address column. This is already supported by the prefix_type parameter - are you proposing that we eliminate the parameter & combine it with flags? > I've also used flags to enable (or disable) suppression of multiple lines of > zeros of constant bytes. > In that case you may want hexdump to return the flags for the next call when > a large buffer is being dumped in fragments. I'm afraid I don't quite follow here, hex_dump_to_buffer doesn't alter the flags, so the caller already knows it. -- Alastair D'Silva mob: 0423 762 819 skype: alastair_dsilva msn: [email protected] blog: http://alastair.d-silva.org Twitter: @EvilDeece _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
