Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The newly added GPU node references core clock R8A77995_CLK_ZG and module clock 112, but neither is implemented in the R8A77995 CPG MSSR clock controller driver. --
commit cb323f9d0762b84aa5d75f999bf135e4920caed4 Author: Niklas Söderlund <[email protected]> arm64: dts: renesas: r8a77995: Add GE8300 GPU node This commit describes the Imagination Technologies PowerVR Rogue GE8300 GPU node for the Renesas R-Car R8A77995 D3 SoC. > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > index 5f3fcef7560cb..c42d96540ce73 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > @@ -1295,6 +1295,21 @@ gic: interrupt-controller@f1010000 { > resets = <&cpg 408>; > }; > > + gpu: gpu@fd000000 { > + compatible = "renesas,r8a77995-gpu", > + "img,img-ge8300", > + "img,img-rogue"; > + reg = <0 0xfd000000 0 0x40000>; > + interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_CORE R8A77995_CLK_ZG>, > + <&cpg CPG_CORE R8A77995_CLK_S3D1>, > + <&cpg CPG_MOD 112>; [Severity: Medium] Will this result in a probe failure when the node is enabled by a board? The newly added GPU node requests the core clock R8A77995_CLK_ZG and module clock 112, but neither appears to be defined in the R8A77995 CPG MSSR clock controller driver (drivers/clk/renesas/r8a77995-cpg-mssr.c). If R8A77995_CLK_ZG is missing from r8a77995_core_clks and index 112 is missing from r8a77995_mod_clks, the clock requests will return -ENOENT and prevent the GPU driver from probing successfully. > + clock-names = "core", "mem", "sys"; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 112>; > + status = "disabled"; > + }; > + [ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
