Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Incorrect use of `enum:` instead of `contains: enum:` in an `if` block breaks schema matching for `compatible` arrays, bypassing power domain validation. --
commit 911441282d51eed161459bbab16231d9b1fcbca8 Author: Niklas Söderlund <[email protected]> dt-bindings: gpu: img, powervr-rogue: Document GE8300 GPU in Renesas R-Car D3 This commit documents the GE8300 GPU present in the Renesas R-Car R8A77995 D3 SoCs. It also updates the power domain constraints to account for the D3 having only one power domain that is always on. > diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > index a1f54dbae3f31..b93f49f1fa0a6 100644 > --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml [ ... ] > @@ -159,14 +165,14 @@ allOf: > - if: > properties: > compatible: > - contains: > - const: thead,th1520-gpu > + enum: > + - renesas,r8a77995-gpu > + - thead,th1520-gpu [Severity: Medium] Does this change break the schema matching for these compatible strings? In Device Tree bindings, the compatible property evaluates as an array of strings. Using "enum:" directly on the compatible array checks if the entire array itself equals one of the scalar string values, which will always evaluate to false. Should this use "contains:" along with "enum:"? By dropping the "contains:" keyword during the transition from a single const to an enum, this condition might silently fail to match both the newly added renesas,r8a77995-gpu and the preexisting thead,th1520-gpu strings. This would bypass the power domain validation constraints intended by the block. > then: > properties: > power-domains: > items: > - - description: The single, unified power domain for the GPU on > the > - TH1520 SoC, integrating all internal IP power domains. > + - description: The single, unified power domain for the GPU. > power-domain-names: false > required: > - power-domains -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
