On Thu, Jun 11, 2026 at 03:48:15PM +0200, Krzysztof Kozlowski wrote: > On 10/06/2026 15:31, Abel Vesa wrote: > >>>>>> @@ -68,6 +68,7 @@ properties: > >>>>>> > >>>>>> - items: > >>>>>> - enum: > >>>>>> + - lenovo,yoga-slim7x-gen11 > >>>>> > >>>>> I imagine you might want different panel variants, just like T14s has > >>>>> LCD and OLED? > >>>> > >>>> I expect this will be the case. > >>> > >>> Then better to prepare for this now, otherwise later you need to change > >>> bindings. If unsure what other variants are, then at least make this > >>> compatible panel-specific, e.g. lenovo,yoga-slim7x-gen11-oled-foo-bar. > >> > >> I took another look at psref [1] and there's only OLED SKUs (today?). > >> There are however, two different resolutions available and both can be > >> touch/notouch. > > > > If the other SKU doesn't have touch, then you might as well mark now this > > one with touch suffix or something like that. > > > If you decide not to have any changes (new compatibles), then at least > please document the above reasoning in commit msg.
If the difference is just the panel or touch, then isn't that captured by the panel and/or touch nodes? OTOH, if it's different firmware builds and generally treated as 2 different devices, then different top-level compatible is probably fine. Rob
