On 6/4/26 11:59 AM, Gopikrishna Garmidi wrote:
>
>
> On 6/4/2026 1:36 PM, Konrad Dybcio wrote:
>> Introduce a device tree for the Glymur-based Lenovo Yoga Slim 7x Gen11
>> laptop. It's fairly similar to the reference design, although there are
>> a couple of major differences, including a different EC.
[...]
>> +&pmh0101_gpios {
>> + key_vol_up_default: key-vol-up-default-state {
>> + pins = "gpio6";
>> + function = "normal";
>> + output-disable;
>> + bias-pull-up;
>> + };
>> +};
> The &pmh0101_gpios node is extended twice here. Please merge both
> pinctrl states into a single block, similar to the fix already sent
> for glymur-crd.dtsi [1].
Thanks! I'll just skip it here, as there's probably a RESIN input
on the debug connector, but it's not soldered (we didn't use it) so
it doesn't really make sense to poke at it unless someone really wants
to go the extra mile
>
> While at it, could you also take a look at [1]? It addresses the
> same issue in glymur-crd.dtsi and has been awaiting review.
>
> [1]
> https://lore.kernel.org/all/20260602-merge-duplicate-pmh0101-gpios-node-v2-1-251107b3d...@oss.qualcomm.com/
I was under the impression I've already done that, but rb'd it now.
Konrad
