On Sat, May 30, 2026 at 03:59:08PM +0200, Maxime Ripard wrote: > __drm_atomic_helper_bridge_state_init() is always called on a freshly > kzalloc-ed state, so the memset is redundant. > > Drop it and document the expectation that the state is already zeroed. > > Signed-off-by: Maxime Ripard <[email protected]>
Reviewed-by: Laurent Pinchart <[email protected]> > --- > drivers/gpu/drm/drm_atomic_state_helper.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c > b/drivers/gpu/drm/drm_atomic_state_helper.c > index 8f04eae7a754..f0688f2d83fe 100644 > --- a/drivers/gpu/drm/drm_atomic_state_helper.c > +++ b/drivers/gpu/drm/drm_atomic_state_helper.c > @@ -889,18 +889,19 @@ EXPORT_SYMBOL(drm_atomic_helper_bridge_destroy_state); > * __drm_atomic_helper_bridge_state_init() - Initialize a bridge state to its > * default > * @state: bridge state to initialize > * @bridge: the bridge this state refers to > * > + * @state is assumed to be zeroed. > + * > * Initializes the bridge state to default values. This is meant to be called > * by the bridge &drm_bridge_funcs.atomic_reset hook for bridges that > subclass > * the bridge state. > */ > void __drm_atomic_helper_bridge_state_init(struct drm_bridge_state *state, > struct drm_bridge *bridge) > { > - memset(state, 0, sizeof(*state)); > __drm_atomic_helper_private_obj_create_state(&bridge->base, > &state->base); > state->bridge = bridge; > } > EXPORT_SYMBOL(__drm_atomic_helper_bridge_state_init); -- Regards, Laurent Pinchart
