On Sat, May 30, 2026 at 03:59:09PM +0200, Maxime Ripard wrote:
[...]
> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index 4ba3a5deef9a..a6c07d339afa 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -502,35 +502,24 @@ struct drm_bridge_funcs {
> struct drm_bridge_state *bridge_state,
> struct drm_crtc_state *crtc_state,
> struct drm_connector_state *conn_state);
>
> /**
> - * @atomic_reset:
> + * @atomic_create_state:
> *
> - * Reset the bridge to a predefined state (or retrieve its current
> - * state) and return a &drm_bridge_state object matching this state.
> - * This function is called at attach time.
> - *
> - * The atomic_reset hook is mandatory if the bridge implements any of
> - * the atomic hooks, and should be left unassigned otherwise. For
> - * bridges that don't subclass &drm_bridge_state, the
> - * drm_atomic_helper_bridge_reset() helper function shall be used to
> - * implement this hook.
> - *
> - * Note that the atomic_reset() semantics is not exactly matching the
> - * reset() semantics found on other components (connector, plane, ...).
> - *
> - * 1. The reset operation happens when the bridge is attached, not when
> - * drm_mode_config_reset() is called
> - * 2. It's meant to be used exclusively on bridges that have been
> - * converted to the ATOMIC API
> + * Allocate a pristine, initialized, state for the bridge
> + * object and return it. This callback must have no side
> + * effects: in particular, the returned state must not be
> + * assigned to the object's state pointer and it must not affect
> + * the hardware state.
> *
> * RETURNS:
> - * A valid drm_bridge_state object in case of success, an ERR_PTR()
> - * giving the reason of the failure otherwise.
> + *
> + * A new, pristine, bridge state instance or an error pointer
> + * on failure.
> */
> - struct drm_bridge_state *(*atomic_reset)(struct drm_bridge *bridge);
> + struct drm_bridge_state *(*atomic_create_state)(struct drm_bridge
> *bridge);
Drivers haven't been converted to use atomic_create_state, isn't this causing
build breaks?
--
Regards,
Liu Ying
