On Tue, Dec 02, 2025 at 09:58:19PM +0100, Andi Shyti wrote: > Hi Jani, > > On Mon, Dec 01, 2025 at 09:46:47AM +0200, Jani Nikula wrote: > > On Sat, 29 Nov 2025, "Yury Norov (NVIDIA)" <[email protected]> wrote: > > > The macro is only used by i915. Move it to a local header and drop from > > > the kernel.h. > > > > > > Signed-off-by: Yury Norov (NVIDIA) <[email protected]> > > > --- > > > drivers/gpu/drm/i915/i915_utils.h | 2 ++ > > > include/linux/kernel.h | 2 -- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i915/i915_utils.h > > > b/drivers/gpu/drm/i915/i915_utils.h > > > index a0c892e4c40d..6c197e968305 100644 > > > --- a/drivers/gpu/drm/i915/i915_utils.h > > > +++ b/drivers/gpu/drm/i915/i915_utils.h > > > > i915_utils.h is on a diet itself. STACK_MAGIC is only used in selftests, > > please put this in i915_selftest.h. > > > > I guess also need to include that from gt/selftest_ring_submission.c, > > the only one that uses STACK_MAGIC but doesn't include i915_selftest.h. > > Doing this cleanups is a bit out of the scope of this patch. > Given that the patch itself has quite a good consensus, let move > it forward and I can take care of the i915 cleanup once it gets > merged.
I'm already testing it in my tree: https://github.com/norov/linux/tree/sm1 If everything is fine, I'll submit v2 with this change, otherwise will schedule it for future improvements.
