On Sun, 30 Nov 2025 21:44:46 +0200 Andy Shevchenko <[email protected]> wrote:
> On Sun, Nov 30, 2025 at 01:16:19PM -0500, Yury Norov wrote: > > On Sat, Nov 29, 2025 at 10:30:23PM +0200, Andy Shevchenko wrote: > > > On Sat, Nov 29, 2025 at 02:53:02PM -0500, Yury Norov (NVIDIA) wrote: > > > > Tracing is a half of the kernel.h in terms of LOCs, although it's a > > > > self-consistent part. Move it to a separate header. > > > > > > > > This is a pure move, except for removing a few 'extern's. > > > > > > Yeah, I also have something similar (but half-baked) locally, the Q I > > > wanted to > > > ask is why a separate header? We have already some of tracing headers. > > > Doesn't > > > suit well? > > > > Just as said in the commit message - this part is more or less > > self-consistent and debugging-oriented. If someone needs to just > > throw trace_printk() in their driver, they will not have to pull > > all the heavy tracing machinery. > > Please, add a summary of this to it. It will be much clearer and based on it > I agree with your judgement. Agreed. Please update the change log stating that the tracing code in kernel.h is only used for quick debugging purposes and is not used for the normal tracing utilities. -- Steve
