Re: [PATCH v4 1/8] drm/sched: Add several job helpers to avoid drivers touching scheduler state

[Niranjana Vishwanathapura]

On Wed, Nov 19, 2025 at 02:40:59PM -0800, Matthew Brost wrote:

Add helpers to see if scheduler is stopped and a jobs signaled state.
Expected to be used driver side on recovery and debug flows.

v4:
- Reorder patch to first in series (Niranjana)
- Also check parent fence for signaling (Niranjana)

Signed-off-by: Matthew Brost <matthew.br...@intel.com>

LGTM.
Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathap...@intel.com>

---
drivers/gpu/drm/scheduler/sched_main.c |  4 ++--
include/drm/gpu_scheduler.h            | 32 ++++++++++++++++++++++++++
2 files changed, 34 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/scheduler/sched_main.c 
b/drivers/gpu/drm/scheduler/sched_main.c
index 1d4f1b822e7b..cf40c18ab433 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -344,7 +344,7 @@ drm_sched_rq_select_entity_fifo(struct drm_gpu_scheduler 
*sched,
 */
static void drm_sched_run_job_queue(struct drm_gpu_scheduler *sched)
{
-       if (!READ_ONCE(sched->pause_submit))
+       if (!drm_sched_is_stopped(sched))
                queue_work(sched->submit_wq, &sched->work_run_job);
}

@@ -354,7 +354,7 @@ static void drm_sched_run_job_queue(struct 
drm_gpu_scheduler *sched)
 */
static void drm_sched_run_free_queue(struct drm_gpu_scheduler *sched)
{
-       if (!READ_ONCE(sched->pause_submit))
+       if (!drm_sched_is_stopped(sched))
                queue_work(sched->submit_wq, &sched->work_free_job);
}

diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
index fb88301b3c45..385bf34e76fe 100644
--- a/include/drm/gpu_scheduler.h
+++ b/include/drm/gpu_scheduler.h
@@ -698,4 +698,36 @@ void drm_sched_entity_modify_sched(struct drm_sched_entity 
*entity,
                                   struct drm_gpu_scheduler **sched_list,
                                   unsigned int num_sched_list);

+/* Inlines */
+
+/**
+ * drm_sched_is_stopped() - DRM is stopped
+ * @sched: DRM scheduler
+ *
+ * Return: True if sched is stopped, False otherwise
+ */
+static inline bool drm_sched_is_stopped(struct drm_gpu_scheduler *sched)
+{
+       return READ_ONCE(sched->pause_submit);
+}
+
+/**
+ * drm_sched_job_is_signaled() - DRM scheduler job is signaled
+ * @job: DRM scheduler job
+ *
+ * Determine if DRM scheduler job is signaled. DRM scheduler should be stopped
+ * to obtain a stable snapshot of state. Both parent fence (hardware fence) and
+ * finished fence (software fence) are check to determine signaling state.
+ *
+ * Return: True if job is signaled, False otherwise
+ */
+static inline bool drm_sched_job_is_signaled(struct drm_sched_job *job)
+{
+       struct drm_sched_fence *s_fence = job->s_fence;
+
+       WARN_ON(!drm_sched_is_stopped(job->sched));
+       return (s_fence->parent && dma_fence_is_signaled(s_fence->parent)) ||
+               dma_fence_is_signaled(&s_fence->finished);
+}
+
#endif
--
2.34.1