> Subject: [v6 03/16] drm/i915: Add intel_color_op > > From: Chaitanya Kumar Borah <[email protected]> > > Add data structure to store intel specific details of colorop > > v2: > - Remove dead code > - Convert macro to function (Jani) > - Remove colorop state as it is not being used > - Refactor to separate file > > Signed-off-by: Chaitanya Kumar Borah <[email protected]> > Signed-off-by: Uma Shankar <[email protected]>
LGTM, Reviewed-by: Suraj Kandpal <[email protected]> > --- > drivers/gpu/drm/i915/Makefile | 1 + > drivers/gpu/drm/i915/display/intel_colorop.c | 10 ++++++++++ > drivers/gpu/drm/i915/display/intel_colorop.h | 13 +++++++++++++ > drivers/gpu/drm/i915/display/intel_display_types.h | 5 +++++ > drivers/gpu/drm/xe/Makefile | 1 + > 5 files changed, 30 insertions(+) > create mode 100644 drivers/gpu/drm/i915/display/intel_colorop.c > create mode 100644 drivers/gpu/drm/i915/display/intel_colorop.h > > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > index 84ec79b64960..b2f591e156cb 100644 > --- a/drivers/gpu/drm/i915/Makefile > +++ b/drivers/gpu/drm/i915/Makefile > @@ -238,6 +238,7 @@ i915-y += \ > display/intel_cdclk.o \ > display/intel_cmtg.o \ > display/intel_color.o \ > + display/intel_colorop.o \ > display/intel_combo_phy.o \ > display/intel_connector.o \ > display/intel_crtc.o \ > diff --git a/drivers/gpu/drm/i915/display/intel_colorop.c > b/drivers/gpu/drm/i915/display/intel_colorop.c > new file mode 100644 > index 000000000000..eaab50d2d126 > --- /dev/null > +++ b/drivers/gpu/drm/i915/display/intel_colorop.c > @@ -0,0 +1,10 @@ > +// SPDX-License-Identifier: MIT > +/* > + * Copyright © 2025 Intel Corporation > + */ > +#include "intel_colorop.h" > + > +struct intel_colorop *to_intel_colorop(struct drm_colorop *colorop) { > + return container_of(colorop, struct intel_colorop, base); } > diff --git a/drivers/gpu/drm/i915/display/intel_colorop.h > b/drivers/gpu/drm/i915/display/intel_colorop.h > new file mode 100644 > index 000000000000..23a29a565949 > --- /dev/null > +++ b/drivers/gpu/drm/i915/display/intel_colorop.h > @@ -0,0 +1,13 @@ > +/* SPDX-License-Identifier: MIT */ > +/* > + * Copyright © 2025 Intel Corporation > + */ > + > +#ifndef __INTEL_COLOROP_H__ > +#define __INTEL_COLOROP_H__ > + > +#include "intel_display_types.h" > + > +struct intel_colorop *to_intel_colorop(struct drm_colorop *colorop); > + > +#endif /* __INTEL_COLOROP_H__ */ > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h > b/drivers/gpu/drm/i915/display/intel_display_types.h > index 00600134bda0..fa39f3236597 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_types.h > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h > @@ -1986,6 +1986,11 @@ struct intel_dp_mst_encoder { > struct intel_connector *connector; > }; > > +struct intel_colorop { > + struct drm_colorop base; > + enum intel_color_block id; > +}; > + > static inline struct intel_encoder * > intel_attached_encoder(struct intel_connector *connector) { diff --git > a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile index > 7b4ca591a4ae..c89cafbd00fa 100644 > --- a/drivers/gpu/drm/xe/Makefile > +++ b/drivers/gpu/drm/xe/Makefile > @@ -240,6 +240,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \ > i915-display/intel_cdclk.o \ > i915-display/intel_cmtg.o \ > i915-display/intel_color.o \ > + i915-display/intel_colorop.o \ > i915-display/intel_combo_phy.o \ > i915-display/intel_connector.o \ > i915-display/intel_crtc.o \ > -- > 2.50.1
