On 11/11/2025 15:51, Akhil P Oommen wrote:
>>> + - |
>>> + #include <dt-bindings/clock/qcom,qcs615-gpucc.h>
>>> + #include <dt-bindings/clock/qcom,qcs615-gcc.h>
>>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> + #include <dt-bindings/power/qcom,rpmhpd.h>
>>> +
>>> + rgmu: rgmu@506a000 {
>>
>> Drop label.
>>
>> Node names should be generic. See also an explanation and list of
>> examples (not exhaustive) in DT specification:
>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>> If you cannot find a name matching your device, please check in kernel
>> sources for similar cases or you can grow the spec (via pull request to
>> DT spec repo).
>
> I guess we can use 'gmu' here as that name is already in use for other
> chipsets?
>
> Ack for all other suggestions. Will update the patch.
Yes, then let's just use existing gmu.
Best regards,
Krzysztof
