On 11/11/25 4:10 PM, Akhil P Oommen wrote: > On 11/7/2025 2:28 PM, Konrad Dybcio wrote: >> On 11/6/25 9:50 PM, Akhil P Oommen wrote: >>> From: Jie Zhang <[email protected]> >>> >>> Add support for Adreno 612 GPU found in SM6150/QCS615 chipsets. >>> A612 falls under ADRENO_6XX_GEN1 family and is a cut down version >>> of A615 GPU. >>> >>> A612 has a new IP called Reduced Graphics Management Unit or RGMU >>> which is a small state machine which helps to toggle GX GDSC >>> (connected to CX rail) to implement IFPC feature. It doesn't support >>> any other features of a full fledged GMU like clock control, resource >>> voting to rpmh etc. So we need linux clock driver support like other >>> gmu-wrapper implementations to control gpu core clock and gpu GX gdsc. >>> This patch skips RGMU core initialization and act more like a >>> gmu-wrapper case. >>> >>> Signed-off-by: Jie Zhang <[email protected]> >>> Signed-off-by: Akhil P Oommen <[email protected]> >>> --- >> >> [...] >> >>> /* Enable fault detection */ >>> - if (adreno_is_a730(adreno_gpu) || >>> + if (adreno_is_a612(adreno_gpu) || >>> + adreno_is_a730(adreno_gpu) || >>> adreno_is_a740_family(adreno_gpu)) >>> gpu_write(gpu, REG_A6XX_RBBM_INTERFACE_HANG_INT_CNTL, (1 << 30) >>> | 0xcfffff); >> >> Downstream sets this to 0x3fffff, but IDK if having a timeout too >> large is an issue > > I reviewed this. It should be 0xcfffff. It looks like the latest tip of > kgsl has an incorrect value for a612 gpu.
Thanks for confirming. This patch looks good to me then! Reviewed-by: Konrad Dybcio <[email protected]> Konrad
