> Subject: [PATCH v3 06/10] drm/i915/alpm: Half LFPS cycle calculation
>
> Add support for half LFPS cycle calculation for DP2.1 ALPM as dependent
> parameters got changed.
>
> v1: Initial version.
> v2: Avoid returning early. [Jani]
>
> Cc: Jouni Högander <[email protected]>
> Signed-off-by: Animesh Manna <[email protected]>
> ---
> drivers/gpu/drm/i915/display/intel_alpm.c | 38 +++++++++++++++--------
> 1 file changed, 25 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c
> b/drivers/gpu/drm/i915/display/intel_alpm.c
> index 81472254ab73..9c37f3ec06aa 100644
> --- a/drivers/gpu/drm/i915/display/intel_alpm.c
> +++ b/drivers/gpu/drm/i915/display/intel_alpm.c
> @@ -70,31 +70,43 @@ static int get_silence_period_symbols(const struct
> intel_crtc_state *crtc_state)
> 1000 / 1000;
> }
>
> -static void get_lfps_cycle_min_max_time(const struct intel_crtc_state
> *crtc_state,
> +static void get_lfps_cycle_min_max_time(struct intel_dp *intel_dp,
> + const struct intel_crtc_state
> *crtc_state,
> int *min, int *max)
> {
> - if (crtc_state->port_clock < 540000) {
> - *min = 65 * LFPS_CYCLE_COUNT;
> - *max = 75 * LFPS_CYCLE_COUNT;
> + struct intel_display *display = to_intel_display(intel_dp);
> +
> + if (intel_dp_is_edp(intel_dp)) {
You seem to need intel_dp only for intel_dp_is_edp no need in that case we can
avoid
waterfalling intel_dp by using intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP)
since you already have crtc_state
Regards,
Suraj Kandpal
> + if (crtc_state->port_clock < 540000) {
> + *min = DISPLAY_VER(display) < 35 ? 65 *
> LFPS_CYCLE_COUNT : 140;
> + *max = DISPLAY_VER(display) < 35 ? 75 *
> LFPS_CYCLE_COUNT : 800;
> + } else {
> + *min = 140;
> + *max = 800;
> + }
> } else {
> - *min = 140;
> - *max = 800;
> + *min = 320;
> + *max = 1600;
> + return;
> }
> }
>
> -static int get_lfps_cycle_time(const struct intel_crtc_state *crtc_state)
> +static int get_lfps_cycle_time(struct intel_dp *intel_dp,
> + const struct intel_crtc_state *crtc_state)
> {
> int tlfps_cycle_min, tlfps_cycle_max;
>
> - get_lfps_cycle_min_max_time(crtc_state, &tlfps_cycle_min,
> + get_lfps_cycle_min_max_time(intel_dp, crtc_state, &tlfps_cycle_min,
> &tlfps_cycle_max);
>
> return tlfps_cycle_min + (tlfps_cycle_max - tlfps_cycle_min) / 2; }
>
> -static int get_lfps_half_cycle_clocks(const struct intel_crtc_state
> *crtc_state)
> +static int get_lfps_half_cycle_clocks(struct intel_dp *intel_dp,
> + const struct intel_crtc_state *crtc_state)
> {
> - return get_lfps_cycle_time(crtc_state) * crtc_state->port_clock / 1000
> /
> + return get_lfps_cycle_time(intel_dp, crtc_state) *
> + crtc_state->port_clock / 1000 /
> 1000 / (2 * LFPS_CYCLE_COUNT);
> }
>
> @@ -125,7 +137,7 @@ static int get_establishment_period(struct intel_dp
> *intel_dp,
> if (lttpr_count) {
> int tlw = 13000;
> int tcs = 10000;
> - int tlfps_period = get_lfps_cycle_time(crtc_state);
> + int tlfps_period = get_lfps_cycle_time(intel_dp, crtc_state);
> int tdcs = (SILENCE_PERIOD_TIME + t1 + tcs +
> (lttpr_count - 1) * (tlw + tlfps_period));
> int tacds = 70000;
> @@ -184,7 +196,7 @@ static int _lnl_compute_aux_less_wake_time(struct
> intel_dp *intel_dp,
> int establishment_period = get_establishment_period(intel_dp,
> crtc_state);
> int switch_to_active = get_switch_to_active(crtc_state);
>
> - return DIV_ROUND_UP(tphy2_p2_to_p0 +
> get_lfps_cycle_time(crtc_state) +
> + return DIV_ROUND_UP(tphy2_p2_to_p0 +
> get_lfps_cycle_time(intel_dp,
> +crtc_state) +
> establishment_period + switch_to_active, 1000); }
>
> @@ -202,7 +214,7 @@ _lnl_compute_aux_less_alpm_params(struct
> intel_dp *intel_dp,
> aux_less_wake_time);
> silence_period = get_silence_period_symbols(crtc_state);
>
> - lfps_half_cycle = get_lfps_half_cycle_clocks(crtc_state);
> + lfps_half_cycle = get_lfps_half_cycle_clocks(intel_dp, crtc_state);
>
> if (aux_less_wake_lines > ALPM_CTL_AUX_LESS_WAKE_TIME_MASK
> ||
> silence_period > PORT_ALPM_CTL_SILENCE_PERIOD_MASK ||
> --
> 2.29.0
