Reviewed-by: Adrián Larumbe <[email protected]> On 30.10.2025 09:34, Boris Brezillon wrote: > group_free_queue() can be called on a partially initialized queue > object if something fails group_create_queue(). Make sure we don't > call drm_sched_entity_destroy() on a entity that hasn't been > initialized. > > Fixes: 7d9c3442b02a ("drm/panthor: Defer scheduler entitiy destruction to > queue release") > Signed-off-by: Boris Brezillon <[email protected]> > --- > drivers/gpu/drm/panthor/panthor_sched.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c > b/drivers/gpu/drm/panthor/panthor_sched.c > index a0a31aa6c6bc..552542f70cab 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -886,7 +886,8 @@ static void group_free_queue(struct panthor_group *group, > struct panthor_queue * > if (IS_ERR_OR_NULL(queue)) > return; > > - drm_sched_entity_destroy(&queue->entity); > + if (queue->entity.fence_context) > + drm_sched_entity_destroy(&queue->entity); > > if (queue->scheduler.ops) > drm_sched_fini(&queue->scheduler); > -- > 2.51.0
Adrian Larumbe
