On Thu, Oct 30, 2025 at 09:34:45AM +0100, Boris Brezillon wrote:
> In practice it's not going to fail because we're passing the current
> sanity checks done by drm_sched_entity_init(), and that's the only
> reason it would return an error, but better safe than sorry.
> 
> Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block")
> Signed-off-by: Boris Brezillon <[email protected]>

For the whole series:

Reviewed-by: Liviu Dudau <[email protected]>

Best regards,
Liviu

> ---
>  drivers/gpu/drm/panthor/panthor_sched.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_sched.c 
> b/drivers/gpu/drm/panthor/panthor_sched.c
> index df76653e649a..a0a31aa6c6bc 100644
> --- a/drivers/gpu/drm/panthor/panthor_sched.c
> +++ b/drivers/gpu/drm/panthor/panthor_sched.c
> @@ -3380,6 +3380,8 @@ group_create_queue(struct panthor_group *group,
>  
>       drm_sched = &queue->scheduler;
>       ret = drm_sched_entity_init(&queue->entity, 0, &drm_sched, 1, NULL);
> +     if (ret)
> +             goto err_free_queue;
>  
>       return queue;
>  
> -- 
> 2.51.0
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

Reply via email to