On 10/16/25 12:28 PM, Joel Fernandes wrote: >> On Oct 16, 2025, at 1:48 PM, Yury Norov <[email protected]> wrote: >> On Thu, Oct 16, 2025 at 11:13:21AM -0400, Joel Fernandes wrote: ... >> Can you please fix line length issues before v8? >> >> $ awk '{print length}' drivers/gpu/nova-core/bitfield.rs | sort -rn | uniq -c >> 1 118 >> 1 116 >> 1 113 >> 1 109 >> 1 105 >> 1 103 > > That is intentional. I will look again but long lines can be a matter of style > and if wrapping effects readability then we do not want to do that. That is
This is true, but let's be very mindful about pushing that *subjective* readability thing--and strongly prefer Rust's 100 line length convention. The larger Rust for Linux has been quite diligent about trying to stay within that length. In this case, most or even all of these can stay under 100 lines, I suspect. > why it is a checkpatch warning not an error. We have to look it case by case. > thanks, -- John Hubbard
