On Wed Oct 8, 2025 at 2:12 AM CEST, Alistair Popple wrote:
> --- a/drivers/gpu/nova-core/firmware/gsp.rs
> +++ b/drivers/gpu/nova-core/firmware/gsp.rs
> @@ -131,7 +131,7 @@ pub(crate) struct GspFirmware {
> /// Size in bytes of the firmware contained in [`Self::fw`].
> pub size: usize,
> /// Device-mapped GSP signatures matching the GPU's [`Chipset`].
> - signatures: DmaObject,
> + pub signatures: DmaObject,
> /// GSP bootloader, verifies the GSP firmware before loading and running
> it.
> pub bootloader: RiscvFirmware,
> }
> @@ -216,7 +216,6 @@ pub(crate) fn new<'a, 'b>(
> }))
> }
>
> - #[expect(unused)]
> /// Returns the DMA handle of the radix3 level 0 page table.
> pub(crate) fn radix3_dma_handle(&self) -> DmaAddress {
> self.level0.dma_handle()
> diff --git a/drivers/gpu/nova-core/firmware/riscv.rs
> b/drivers/gpu/nova-core/firmware/riscv.rs
> index 04f1283abb72..76d0d36fee3e 100644
> --- a/drivers/gpu/nova-core/firmware/riscv.rs
> +++ b/drivers/gpu/nova-core/firmware/riscv.rs
> @@ -55,11 +55,11 @@ fn new(bin_fw: &BinFirmware<'_>) -> Result<Self> {
> #[expect(unused)]
> pub(crate) struct RiscvFirmware {
> /// Offset at which the code starts in the firmware image.
> - code_offset: u32,
> + pub code_offset: u32,
> /// Offset at which the data starts in the firmware image.
> - data_offset: u32,
> + pub data_offset: u32,
> /// Offset at which the manifest starts in the firmware image.
> - manifest_offset: u32,
> + pub manifest_offset: u32,
> /// Application version.
> app_version: u32,
> /// Device-mapped firmware image.
As mentioned in a previous patch, the member visibility should at most match the
stuct visibility.
Otherwise, LGTM!
