On Wed, 2025-10-08 at 11:12 +1100, Alistair Popple wrote:
> +
> +    /// Write the application version to the OS register.
> +    #[expect(dead_code)]
> +    pub(crate) fn write_os_version(&self, bar: &Bar0, app_version: u32) -> 
> Result<()> {
> +        regs::NV_PFALCON_FALCON_OS::default()
> +            .set_value(app_version)
> +            .write(bar, &E::ID);
> +        Ok(())
> +    }

I should have noticed this in v3, but why return Result here?  This is just 
like is_riscv_active
-- this function cannot fail.

Reply via email to