On 9/23/25 11:04 AM, Biju Das wrote:
Hello Biju,
-#define CLOCKSET1_CLKINSEL_EXTAL (0 << 2)
0
-#define CLOCKSET1_CLKINSEL_DIG (1 << 2)
4
-#define CLOCKSET1_CLKINSEL_DU (1 << 3)
8
+#define CLOCKSET1_CLKINSEL_MASK (3 << 2)
+#define CLOCKSET1_CLKINSEL_EXTAL 0
+#define CLOCKSET1_CLKINSEL_DIG 1
+#define CLOCKSET1_CLKINSEL_DU 2
Looks like this patch breaks existing functionality,
There are no users of this bitfield, hence no updates to the DSI driver.
(see commit message). Therefore there is no breakage.
Can we remove it, if there are no users? Or you still prefer to keep it.
The header does contain a complete list of bitfields, that's why I kept it.