On 9/23/25 7:45 AM, Biju Das wrote:
Hello Biju,
Introduce CLOCKSET1_CLKINSEL_MASK macro and remove bitshift from values to make
this bitfield usable
with FIELD_PREP(). There are no users of this bitfield, hence no updates to the
DSI driver.
...
-#define CLOCKSET1_CLKINSEL_EXTAL (0 << 2)
0
-#define CLOCKSET1_CLKINSEL_DIG (1 << 2)
4
-#define CLOCKSET1_CLKINSEL_DU (1 << 3)
8
+#define CLOCKSET1_CLKINSEL_MASK (3 << 2)
+#define CLOCKSET1_CLKINSEL_EXTAL 0
+#define CLOCKSET1_CLKINSEL_DIG 1
+#define CLOCKSET1_CLKINSEL_DU 2
Looks like this patch breaks existing functionality,
There are no users of this bitfield, hence no updates to the DSI driver.
(see commit message). Therefore there is no breakage.
as the macro values are different.
Use FIELD_PREP(CLOCKSET1_CLKINSEL_MASK,
CLOCKSET1_CLKINSEL_{EXTAL,DIG,DU}) with these updated macros, that will
place the value in the correct location .
