On 10/13/2025, Fabio Estevam wrote:
> imx6sx.dtsi has the following lcdif entries:
>
> compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
>
> This causes the following dt-schema warning:
>
> ['fsl,imx6sx-lcdif', 'fsl,imx28-lcdif'] is too long
>
> To keep DT compatibility, document 'fsl,imx28-lcdif' as a possible
> 'fsl,imx6sx-lcdif' fallback.
>
> Signed-off-by: Fabio Estevam <[email protected]>
> Acked-by: Rob Herring (Arm) <[email protected]>
> Reviewed-by: Ahmad Fatoum <[email protected]>
> ---
> Hi Liu Ying,
Hi,
>
> Could you please help apply patches 1 and 2 to drm-misc?
As Marek and Stefan are the two maintainers of "MXSFB DRM DRIVER" according
to MAINTAINERS, they are the first two supposed to conduct apply if needed.
But I can help apply if they don't respond and all my comments are addressed.
>
> I got several Reviewed-by/Acked-by tags on this series, but the patches were
> not applied during several kernel cycles.
>
> Thanks
>
> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> index 2dd0411ec651..ce31b873fb95 100644
> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> @@ -19,7 +19,6 @@ properties:
> - enum:
> - fsl,imx23-lcdif
> - fsl,imx28-lcdif
> - - fsl,imx6sx-lcdif
> - fsl,imx8mp-lcdif
> - fsl,imx93-lcdif
> - items:
> @@ -32,6 +31,10 @@ properties:
> - fsl,imx8mn-lcdif
> - fsl,imx8mq-lcdif
> - const: fsl,imx6sx-lcdif
> + - items:
> + - enum:
> + - fsl,imx6sx-lcdif
> + - const: fsl,imx28-lcdif
Strictly speaking, I don't think i.MX6SX LCDIF is compatible with i.MX28 LCDIF
because at least i.MX28 LCDIF has the version and debug{0,1,2} registers(at
0x1c0, 0x1d0, 0x1e0 and 0x1f0) while i.MX6SX LCDIF hasn't.
>
> reg:
> maxItems: 1
> @@ -199,7 +202,7 @@ examples:
> #include <dt-bindings/interrupt-controller/arm-gic.h>
>
> display-controller@2220000 {
> - compatible = "fsl,imx6sx-lcdif";
> + compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
> reg = <0x02220000 0x4000>;
> interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>,
--
Regards,
Liu Ying
